proxmox-mirrors/qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu synced 2025-08-09 08:10:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

VMDK: fix leak of extent_file

Browse Source 
Release extent_file on error in vmdk_parse_extents. Added closing files
in freeing extents.

Signed-off-by: Fam Zheng <famcool@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Fam Zheng 2011-09-19 10:26:42 +08:00 committed by Kevin Wolf
parent 7285477ab1
commit b3c0bfb6f9
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
block/vmdk.c
View File

@ -179,11 +179,16 @@ static void vmdk_free_extents(BlockDriverState *bs)
{ {
int i; int i;
BDRVVmdkState *s = bs->opaque; BDRVVmdkState *s = bs->opaque;
VmdkExtent *e;
for (i = 0; i < s->num_extents; i++) { for (i = 0; i < s->num_extents; i++) {
g_free(s->extents[i].l1_table); e = &s->extents[i];
g_free(s->extents[i].l2_cache); g_free(e->l1_table);
g_free(s->extents[i].l1_backup_table); g_free(e->l2_cache);
g_free(e->l1_backup_table);
if (e->file != bs->file) {
bdrv_delete(e->file);
}
} }
g_free(s->extents); g_free(s->extents);
} }
@ -619,12 +624,13 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int flags,
s->desc_offset = 0; s->desc_offset = 0;
ret = vmdk_parse_extents(buf, bs, bs->file->filename); ret = vmdk_parse_extents(buf, bs, bs->file->filename);
if (ret) { if (ret) {
vmdk_free_extents(bs);
return ret; return ret;
} }
/* try to open parent images, if exist */ /* try to open parent images, if exist */
if (vmdk_parent_open(bs)) { if (vmdk_parent_open(bs)) {
g_free(s->extents); vmdk_free_extents(bs);
return -EINVAL; return -EINVAL;
} }
s->parent_cid = vmdk_read_cid(bs, 1); s->parent_cid = vmdk_read_cid(bs, 1);