proxmox-mirrors/qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu synced 2025-06-15 11:15:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "gdbstub: Simplify find_cpu()"

Browse Source 
This reverts commit c52a6b67c1, which
replaced cpu_index() with cpu_index field, leading to deviation from
thread ID for NTPL and off-by-one otherwise.

Reported-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Andreas Färber 2013-07-09 20:50:52 +02:00
parent 071b3364e7
commit aa48dd9319
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gdbstub.c
View File

@ -2071,13 +2071,17 @@ static void gdb_set_cpu_pc(GDBState *s, target_ulong pc)
static CPUArchState *find_cpu(uint32_t thread_id) static CPUArchState *find_cpu(uint32_t thread_id)
{ {
CPUArchState *env;
CPUState *cpu; CPUState *cpu;
cpu = qemu_get_cpu(thread_id); for (env = first_cpu; env != NULL; env = env->next_cpu) {
if (cpu == NULL) { cpu = ENV_GET_CPU(env);
return NULL; if (cpu_index(cpu) == thread_id) {
return env;
} }
return cpu->env_ptr; }
return NULL;
} }
static int gdb_handle_packet(GDBState *s, const char *line_buf) static int gdb_handle_packet(GDBState *s, const char *line_buf)