proxmox-mirrors/qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu synced 2025-08-08 10:44:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sheepdog: cleanup find_vdi_name

Browse Source 
This makes 'filename' and 'tag' constant variables, and renames
'for_snapshot' to 'lock' to clear how it works.

Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
MORITA Kazutaka 2013-04-26 01:19:51 +09:00 committed by Stefan Hajnoczi
parent c3ca988d2b
commit 982dcbf4cb
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
block/sheepdog.c
View File

@ -941,8 +941,9 @@ static int parse_vdiname(BDRVSheepdogState *s, const char *filename,
return ret; return ret;
} }
static int find_vdi_name(BDRVSheepdogState *s, char *filename, uint32_t snapid, static int find_vdi_name(BDRVSheepdogState *s, const char *filename,
char *tag, uint32_t *vid, int for_snapshot) uint32_t snapid, const char *tag, uint32_t *vid,
bool lock)
{ {
int ret, fd; int ret, fd;
SheepdogVdiReq hdr; SheepdogVdiReq hdr;
@ -963,10 +964,10 @@ static int find_vdi_name(BDRVSheepdogState *s, char *filename, uint32_t snapid,
strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN); strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
memset(&hdr, 0, sizeof(hdr)); memset(&hdr, 0, sizeof(hdr));
if (for_snapshot) { if (lock) {
hdr.opcode = SD_OP_GET_VDI_INFO;
} else {
hdr.opcode = SD_OP_LOCK_VDI; hdr.opcode = SD_OP_LOCK_VDI;
} else {
hdr.opcode = SD_OP_GET_VDI_INFO;
} }
wlen = SD_MAX_VDI_LEN + SD_MAX_VDI_TAG_LEN; wlen = SD_MAX_VDI_LEN + SD_MAX_VDI_TAG_LEN;
hdr.proto_ver = SD_PROTO_VER; hdr.proto_ver = SD_PROTO_VER;
@ -1205,7 +1206,7 @@ static int sd_open(BlockDriverState *bs, QDict *options, int flags)
goto out; goto out;
} }
ret = find_vdi_name(s, vdi, snapid, tag, &vid, 0); ret = find_vdi_name(s, vdi, snapid, tag, &vid, true);
if (ret) { if (ret) {
goto out; goto out;
} }
@ -1921,7 +1922,7 @@ static int sd_snapshot_goto(BlockDriverState *bs, const char *snapshot_id)
pstrcpy(tag, sizeof(tag), s->name); pstrcpy(tag, sizeof(tag), s->name);
} }
ret = find_vdi_name(s, vdi, snapid, tag, &vid, 1); ret = find_vdi_name(s, vdi, snapid, tag, &vid, false);
if (ret) { if (ret) {
error_report("Failed to find_vdi_name"); error_report("Failed to find_vdi_name");
goto out; goto out;