proxmox-mirrors/qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu synced 2025-08-07 09:40:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

monitor: avoid direct use of global variable *mon_cmds

Browse Source 
New member *cmd_table is added in structure Monitor to avoid direct usage of
*mon_cmds. Now monitor have an associated command table, when global variable
*info_cmds is also discarded, structure Monitor would gain full control about
how to deal with user input.

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
Wenchao Xia 2013-08-27 20:38:20 +08:00 committed by Luiz Capitulino
parent b01fe89e91
commit 7717239dc1
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
monitor.c
View File

@ -195,6 +195,7 @@ struct Monitor {
CPUState *mon_cpu; CPUState *mon_cpu;
BlockDriverCompletionFunc *password_completion_cb; BlockDriverCompletionFunc *password_completion_cb;
void *password_opaque; void *password_opaque;
mon_cmd_t *cmd_table;
QError *error; QError *error;
QLIST_HEAD(,mon_fd_t) fds; QLIST_HEAD(,mon_fd_t) fds;
QLIST_ENTRY(Monitor) entry; QLIST_ENTRY(Monitor) entry;
@ -687,6 +688,8 @@ static void monitor_data_init(Monitor *mon)
{ {
memset(mon, 0, sizeof(Monitor)); memset(mon, 0, sizeof(Monitor));
mon->outbuf = qstring_new(); mon->outbuf = qstring_new();
/* Use *mon_cmds by default. */
mon->cmd_table = mon_cmds;
} }
static void monitor_data_destroy(Monitor *mon) static void monitor_data_destroy(Monitor *mon)
@ -767,7 +770,7 @@ static void help_cmd(Monitor *mon, const char *name)
if (name && !strcmp(name, "info")) { if (name && !strcmp(name, "info")) {
help_cmd_dump(mon, info_cmds, "info ", NULL); help_cmd_dump(mon, info_cmds, "info ", NULL);
} else { } else {
help_cmd_dump(mon, mon_cmds, "", name); help_cmd_dump(mon, mon->cmd_table, "", name);
if (name && !strcmp(name, "log")) { if (name && !strcmp(name, "log")) {
const QEMULogItem *item; const QEMULogItem *item;
monitor_printf(mon, "Log items (comma separated):\n"); monitor_printf(mon, "Log items (comma separated):\n");
@ -3995,7 +3998,7 @@ static void handle_user_command(Monitor *mon, const char *cmdline)
qdict = qdict_new(); qdict = qdict_new();
cmd = monitor_parse_command(mon, cmdline, 0, mon_cmds, qdict); cmd = monitor_parse_command(mon, cmdline, 0, mon->cmd_table, qdict);
if (!cmd) if (!cmd)
goto out; goto out;
@ -4184,12 +4187,12 @@ static void monitor_find_completion(Monitor *mon,
else else
cmdname = args[0]; cmdname = args[0];
readline_set_completion_index(mon->rs, strlen(cmdname)); readline_set_completion_index(mon->rs, strlen(cmdname));
for(cmd = mon_cmds; cmd->name != NULL; cmd++) { for (cmd = mon->cmd_table; cmd->name != NULL; cmd++) {
cmd_completion(mon, cmdname, cmd->name); cmd_completion(mon, cmdname, cmd->name);
} }
} else { } else {
/* find the command */ /* find the command */
for (cmd = mon_cmds; cmd->name != NULL; cmd++) { for (cmd = mon->cmd_table; cmd->name != NULL; cmd++) {
if (compare_cmd(args[0], cmd->name)) { if (compare_cmd(args[0], cmd->name)) {
break; break;
} }
@ -4240,7 +4243,7 @@ static void monitor_find_completion(Monitor *mon,
} }
} else if (!strcmp(cmd->name, "help|?")) { } else if (!strcmp(cmd->name, "help|?")) {
readline_set_completion_index(mon->rs, strlen(str)); readline_set_completion_index(mon->rs, strlen(str));
for (cmd = mon_cmds; cmd->name != NULL; cmd++) { for (cmd = mon->cmd_table; cmd->name != NULL; cmd++) {
cmd_completion(mon, str, cmd->name); cmd_completion(mon, str, cmd->name);
} }
} }