proxmox-mirrors/qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu synced 2025-08-14 17:19:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sh4: Fix potential crash in debug code

Browse Source 
cppcheck reports this error:

qemu/hw/sh_intc.c:390: error: Possible null pointer dereference:
 s - otherwise it is redundant to check if s is null at line 385

If s were NULL, the printf() statement would crash.
Setting braces fixes this bug.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Reviewed-by: Andreas Färber <andreas.faerber@web.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This commit is contained in:
Stefan Weil 2011-07-20 20:56:35 +02:00 committed by Stefan Hajnoczi
parent 625f9e1f54
commit 6f9faa91f5
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/sh_intc.c
View File

@ -382,7 +382,7 @@ void sh_intc_register_sources(struct intc_desc *desc,
sh_intc_register_source(desc, vect->enum_id, groups, nr_groups);
s = sh_intc_source(desc, vect->enum_id);
if (s)
if (s) {
s->vect = vect->vect;
#ifdef DEBUG_INTC_SOURCES
@ -390,6 +390,7 @@ void sh_intc_register_sources(struct intc_desc *desc,
vect->enum_id, s->vect, s->enable_count, s->enable_max);
#endif
}
}
if (groups) {
for (i = 0; i < nr_groups; i++) {