proxmox-mirrors/qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu synced 2025-08-07 07:30:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vfio-pci: Clang cleanup

Browse Source 
Blue Swirl reports that Clang doesn't like the structure we define to
avoid dynamic allocation for a number of calls to VFIO_DEVICE_SET_IRQS.
Adding an element after a variable sized type is a GNU extension.
Switch back to dynamic allocation, which really isn't a problem since
this is only done on interrupt setup changes.

Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Alex Williamson 2012-10-08 08:45:31 -06:00
parent ce59af2dba
commit 1a40313381
1 changed files with 58 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

101
hw/vfio_pci.c
View File

@ -248,24 +248,12 @@ static void vfio_eoi(VFIODevice *vdev)
vfio_unmask_intx(vdev); vfio_unmask_intx(vdev);
} }
typedef struct QEMU_PACKED VFIOIRQSetFD {
struct vfio_irq_set irq_set;
int32_t fd;
} VFIOIRQSetFD;
static int vfio_enable_intx(VFIODevice *vdev) static int vfio_enable_intx(VFIODevice *vdev)
{ {
VFIOIRQSetFD irq_set_fd = {
.irq_set = {
.argsz = sizeof(irq_set_fd),
.flags = VFIO_IRQ_SET_DATA_EVENTFD | VFIO_IRQ_SET_ACTION_TRIGGER,
.index = VFIO_PCI_INTX_IRQ_INDEX,
.start = 0,
.count = 1,
},
};
uint8_t pin = vfio_pci_read_config(&vdev->pdev, PCI_INTERRUPT_PIN, 1); uint8_t pin = vfio_pci_read_config(&vdev->pdev, PCI_INTERRUPT_PIN, 1);
int ret; int ret, argsz;
struct vfio_irq_set *irq_set;
int32_t *pfd;
if (!pin) { if (!pin) {
return 0; return 0;
@ -280,12 +268,24 @@ static int vfio_enable_intx(VFIODevice *vdev)
return ret; return ret;
} }
irq_set_fd.fd = event_notifier_get_fd(&vdev->intx.interrupt); argsz = sizeof(*irq_set) + sizeof(*pfd);
qemu_set_fd_handler(irq_set_fd.fd, vfio_intx_interrupt, NULL, vdev);
if (ioctl(vdev->fd, VFIO_DEVICE_SET_IRQS, &irq_set_fd)) { irq_set = g_malloc0(argsz);
irq_set->argsz = argsz;
irq_set->flags = VFIO_IRQ_SET_DATA_EVENTFD | VFIO_IRQ_SET_ACTION_TRIGGER;
irq_set->index = VFIO_PCI_INTX_IRQ_INDEX;
irq_set->start = 0;
irq_set->count = 1;
pfd = (int32_t *)&irq_set->data;
*pfd = event_notifier_get_fd(&vdev->intx.interrupt);
qemu_set_fd_handler(*pfd, vfio_intx_interrupt, NULL, vdev);
ret = ioctl(vdev->fd, VFIO_DEVICE_SET_IRQS, irq_set);
g_free(irq_set);
if (ret) {
error_report("vfio: Error: Failed to setup INTx fd: %m\n"); error_report("vfio: Error: Failed to setup INTx fd: %m\n");
qemu_set_fd_handler(irq_set_fd.fd, NULL, NULL, vdev); qemu_set_fd_handler(*pfd, NULL, NULL, vdev);
event_notifier_cleanup(&vdev->intx.interrupt); event_notifier_cleanup(&vdev->intx.interrupt);
return -errno; return -errno;
} }
@ -426,18 +426,25 @@ static int vfio_msix_vector_use(PCIDevice *pdev,
error_report("vfio: failed to enable vectors, %d\n", ret); error_report("vfio: failed to enable vectors, %d\n", ret);
} }
} else { } else {
VFIOIRQSetFD irq_set_fd = { int argsz;
.irq_set = { struct vfio_irq_set *irq_set;
.argsz = sizeof(irq_set_fd), int32_t *pfd;
.flags = VFIO_IRQ_SET_DATA_EVENTFD |
VFIO_IRQ_SET_ACTION_TRIGGER, argsz = sizeof(*irq_set) + sizeof(*pfd);
.index = VFIO_PCI_MSIX_IRQ_INDEX,
.start = nr, irq_set = g_malloc0(argsz);
.count = 1, irq_set->argsz = argsz;
}, irq_set->flags = VFIO_IRQ_SET_DATA_EVENTFD |
.fd = event_notifier_get_fd(&vector->interrupt), VFIO_IRQ_SET_ACTION_TRIGGER;
}; irq_set->index = VFIO_PCI_MSIX_IRQ_INDEX;
ret = ioctl(vdev->fd, VFIO_DEVICE_SET_IRQS, &irq_set_fd); irq_set->start = nr;
irq_set->count = 1;
pfd = (int32_t *)&irq_set->data;
*pfd = event_notifier_get_fd(&vector->interrupt);
ret = ioctl(vdev->fd, VFIO_DEVICE_SET_IRQS, irq_set);
g_free(irq_set);
if (ret) { if (ret) {
error_report("vfio: failed to modify vector, %d\n", ret); error_report("vfio: failed to modify vector, %d\n", ret);
} }
@ -450,17 +457,9 @@ static void vfio_msix_vector_release(PCIDevice *pdev, unsigned int nr)
{ {
VFIODevice *vdev = DO_UPCAST(VFIODevice, pdev, pdev); VFIODevice *vdev = DO_UPCAST(VFIODevice, pdev, pdev);
VFIOMSIVector *vector = &vdev->msi_vectors[nr]; VFIOMSIVector *vector = &vdev->msi_vectors[nr];
VFIOIRQSetFD irq_set_fd = { int argsz;
.irq_set = { struct vfio_irq_set *irq_set;
.argsz = sizeof(irq_set_fd), int32_t *pfd;
.flags = VFIO_IRQ_SET_DATA_EVENTFD |
VFIO_IRQ_SET_ACTION_TRIGGER,
.index = VFIO_PCI_MSIX_IRQ_INDEX,
.start = nr,
.count = 1,
},
.fd = -1,
};
DPRINTF("%s(%04x:%02x:%02x.%x) vector %d released\n", __func__, DPRINTF("%s(%04x:%02x:%02x.%x) vector %d released\n", __func__,
vdev->host.domain, vdev->host.bus, vdev->host.slot, vdev->host.domain, vdev->host.bus, vdev->host.slot,
@ -472,7 +471,23 @@ static void vfio_msix_vector_release(PCIDevice *pdev, unsigned int nr)
* bouncing through userspace and let msix.c drop it? Not sure. * bouncing through userspace and let msix.c drop it? Not sure.
*/ */
msix_vector_unuse(pdev, nr); msix_vector_unuse(pdev, nr);
ioctl(vdev->fd, VFIO_DEVICE_SET_IRQS, &irq_set_fd);
argsz = sizeof(*irq_set) + sizeof(*pfd);
irq_set = g_malloc0(argsz);
irq_set->argsz = argsz;
irq_set->flags = VFIO_IRQ_SET_DATA_EVENTFD |
VFIO_IRQ_SET_ACTION_TRIGGER;
irq_set->index = VFIO_PCI_MSIX_IRQ_INDEX;
irq_set->start = nr;
irq_set->count = 1;
pfd = (int32_t *)&irq_set->data;
*pfd = -1;
ioctl(vdev->fd, VFIO_DEVICE_SET_IRQS, irq_set);
g_free(irq_set);
if (vector->virq < 0) { if (vector->virq < 0) {
qemu_set_fd_handler(event_notifier_get_fd(&vector->interrupt), qemu_set_fd_handler(event_notifier_get_fd(&vector->interrupt),