qemu-server/PVE
Alexandre Derumier d797bb62c3 cpu hotplug: cannot change feature online
The vCPUs are passed as devices with specific id only when CPU
hot-plug is enable at cold start.

So, we can't enable/disable allow-hotplug online as then vCPU hotplug
API will thrown errors not finding core id.

Not enforcing this could also lead to migration failure, as the QEMU
command line for the target VM could be made different than the one it
was actually running with, causing a crash of the target as Fiona
observed [0].

[0]: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059434.html

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
 [ TL: Reflowed & expanded commit message ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-10-24 11:46:52 +02:00
..
API2 backup, migrate: fix races with suspended VMs that can wake up 2023-10-16 16:48:47 +02:00
CLI qm: remote migration: improve error when storage cannot be found 2023-06-09 09:49:40 +02:00
QemuServer vm start: set higher timeout if using PCI passthrough 2023-10-06 18:12:07 +02:00
VZDump vzdump: assemble: improve error messages 2023-10-23 17:09:41 +02:00
Makefile buildsys: use $(MAKE) instead of make 2019-09-24 18:06:16 +02:00
QemuConfig.pm add memory parser 2023-09-18 17:08:48 +02:00
QemuMigrate.pm backup, migrate: fix races with suspended VMs that can wake up 2023-10-16 16:48:47 +02:00
QemuServer.pm cpu hotplug: cannot change feature online 2023-10-24 11:46:52 +02:00
QMPClient.pm remove left-over mentions of to-be-dropped, outdated QMP commands 2023-06-07 19:36:45 +02:00