Fiona Ebner ae1da616a7 api: create/update vm: avoid printing empty machine string ... While no problem is known with having an empty machine string in the configuration and it was already possible setting an empty machine manually via 'qm set', the behavior changed because of commit 919e69d0 ("machine: add check_and_pin_machine_string() helper") and there is potential for problematic edge cases. Restore the previous behavior. Pinning is also required when there is no given machine type, so the call to check_and_pin_machine_string() should stay unconditional. For update, pinning was recently added by commit 7a9570f3 ("api: update vm config: pin machine version when switching to windows os type"), so bring that in-line with the behavior for create too. Another idea would've been to just return the default machine in check_and_pin_machine_string(), but that would also be a change in behavior. In particular, the default depends on the arch, so an empty machine type will pick the default machine for the currently configured arch even when the arch is later changed. Reported-by: Daniel Herzig <d.herzig@proxmox.com> Fixes: 919e69d0 ("machine: add check_and_pin_machine_string() helper") Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>		2025-01-20 14:43:07 +01:00
..
Qemu	api: delete unused OVF.pm	2024-11-17 16:17:50 +01:00
Makefile	buildsys: use $(MAKE) instead of make	2019-09-24 18:06:16 +02:00
Qemu.pm	api: create/update vm: avoid printing empty machine string	2025-01-20 14:43:07 +01:00