qemu-server/PVE/QemuServer
Fabian Ebner a0d8d8592a drive: volume in-use check: fix fallback path comparison
When checking whether a volume is still referenced by a snapshot, the volid
itself is first checked. When the volid is different, we fall back to comparing
the path.

As the first value to be compared is a volume's path, the second value better be
a volume's path too, and not a snapshot's path.

See also 77019edfe0 for historical context.

The error that led me here:
* had a VM with ZFS over iSCSI storage with an exsiting snapshot
* add new unused drive
* try to remove the unsued drive
* fails, because ZFS (not Pool!) Plugin does not support snapshot paths.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-04-18 17:26:05 +02:00
..
Agent.pm tree wide cleanup of s/return undef/return/ 2020-10-16 16:20:05 +02:00
CGroup.pm add PVE::QemuServer::Cgroup 2020-11-24 12:00:33 +01:00
Cloudinit.pm fix #2670: cloudinit enable SLAAC 2021-03-30 18:25:06 +02:00
CPUConfig.pm anchor CPU flag regex to avoid arbitrary flag suffixes 2021-01-26 19:27:05 +01:00
Drive.pm drive: volume in-use check: fix fallback path comparison 2021-04-18 17:26:05 +02:00
Helpers.pm tree wide cleanup of s/return undef/return/ 2020-10-16 16:20:05 +02:00
ImportDisk.pm qm importdisk: tell user to what VM disk we actually imported 2019-10-29 19:11:21 +01:00
Machine.pm can_run_pve_machine_version: PVE version can really be optional 2021-03-05 18:49:06 +01:00
Makefile add PVE::QemuServer::Cgroup 2020-11-24 12:00:33 +01:00
Memory.pm tree wide cleanups 2020-10-16 18:03:32 +02:00
Monitor.pm mon_cmd: add explicit return 2019-11-30 17:24:55 +01:00
OVF.pm tree wide cleanup of s/return undef/return/ 2020-10-16 16:20:05 +02:00
PCI.pm PCI: use warnings/strict and fix setting $vga from config2command 2020-10-16 18:03:32 +02:00
USB.pm tree wide cleanup of s/return undef/return/ 2020-10-16 16:20:05 +02:00