Go to file
Fabian Ebner 0783c3c271 migration: move finishing block jobs to phase2 for better/uniform error handling
avoids the possibility to die during phase3_cleanup and instead of needing to
duplicate the cleanup ourselves, benefit from phase2_cleanup doing so.

The duplicate cleanup was also very incomplete: it didn't stop the remote kvm
process (leading to 'VM already running' when trying to migrate again
afterwards), but it removed its disks, and it didn't unlock the config, didn't
close the tunnel and didn't cancel the block-dirty bitmaps.

Since migrate_cancel should do nothing after the (non-storage) migrate process
has completed, even that cleanup step is fine here.

Since phase3 is empty at the moment, the order of operations is still the same.

Also add a test, that would complain about finish_tunnel not being called before
this patch. That test also checks that local disks are not already removed
before finishing the block jobs.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-04-18 18:30:41 +02:00
debian d/control: bump pve-storage dependency for new vdisk param 2021-04-18 18:04:29 +02:00
PVE migration: move finishing block jobs to phase2 for better/uniform error handling 2021-04-18 18:30:41 +02:00
qemu-configs move qemu-configs to own directory 2019-09-24 18:59:35 +02:00
qmeventd qmeventd: fix more early broken lines 2021-02-12 09:52:51 +01:00
test migration: move finishing block jobs to phase2 for better/uniform error handling 2021-04-18 18:30:41 +02:00
vm-network-scripts sdn: use sdn tap_create|plug 2020-03-10 19:08:31 +01:00
.gitignore d/cointrol is not autogenerated anymore, remove from .gitignore 2019-01-31 12:10:51 +01:00
bootsplash.jpg add seabios bootsplash and use it 2016-09-08 12:22:01 +02:00
bootsplash.xcf add seabios bootsplash and use it 2016-09-08 12:22:01 +02:00
Makefile buildsys: clean: remove migration test runtime files 2021-01-12 12:01:41 +01:00
modules-load.conf remove unnecessary init.d, postint, postrm and qmupdate scripts 2015-02-27 16:09:41 +01:00
qm convert qmrestore into a PVE::CLI class 2015-10-05 13:10:24 +02:00
qmextract remove legacy sparsecp 2017-08-23 10:03:37 +02:00
qmrestore convert qmrestore into a PVE::CLI class 2015-10-05 13:10:24 +02:00