From e4263214b8b708b71be9d256e153531e51002bdb Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Thu, 11 May 2023 13:43:17 +0200 Subject: [PATCH] disable SMM check: always return false for virt machine type There is no 'smm' flag for the 'virt' machine type. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index c1d0fd2d..ab33aa37 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3543,7 +3543,9 @@ sub query_understood_cpu_flags { # Since commit 277d33454f77ec1d1e0bc04e37621e4dd2424b67 in pve-qemu, smm is not off by default # anymore. But smm=off seems to be required when using SeaBIOS and serial display. my sub should_disable_smm { - my ($conf, $vga) = @_; + my ($conf, $vga, $machine) = @_; + + return if $machine =~ m/^virt/; # there is no smm flag that could be disabled return (!defined($conf->{bios}) || $conf->{bios} eq 'seabios') && $vga->{type} && $vga->{type} =~ m/^(serial\d+|none)$/; @@ -4155,7 +4157,7 @@ sub config_to_command { push @$machineFlags, 'accel=tcg'; } - push @$machineFlags, 'smm=off' if should_disable_smm($conf, $vga); + push @$machineFlags, 'smm=off' if should_disable_smm($conf, $vga, $machine_type); my $machine_type_min = $machine_type; if ($add_pve_version) {