From e0e036e1ba3b8355e2d9f86557dbb5a1557fe66c Mon Sep 17 00:00:00 2001 From: Leo Nunner Date: Mon, 17 Oct 2022 15:24:00 +0200 Subject: [PATCH] fix #4284: add read-only to non-hotpluggable disk options Changing the read-only status of a disk is not possible through QMP, so it needs to be exempt from the hotpluggable values as to notify the user. Signed-off-by: Leo Nunner --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 759f3623..3a8bc269 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5280,7 +5280,8 @@ sub vmconfig_update_disk { safe_string_ne($drive->{iothread}, $old_drive->{iothread}) || safe_string_ne($drive->{queues}, $old_drive->{queues}) || safe_string_ne($drive->{cache}, $old_drive->{cache}) || - safe_string_ne($drive->{ssd}, $old_drive->{ssd})) { + safe_string_ne($drive->{ssd}, $old_drive->{ssd}) || + safe_string_ne($drive->{ro}, $old_drive->{ro})) { die "skip\n"; }