proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-10-04 13:49:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

live import: do not auto-dismiss stream job to improve error message and detection

Browse Source 
upon failure. Otherwise, the job would disappear too quickly from the
job list and cannot be queried for the actual error anymore.

Relevant part of the error in an actual example:

Before:
> VM 106 qmp command 'blockdev-del' failed - Node 'drive-scsi0-restore' is busy: node is used as backing hd of '#block655'

After:
> block job (stream) error: restore-scsi0: No space left on device (io-status: ok)

Note that previously, it was not even detected that the stream job
failed and the error message is because the subsequent cleanup failed.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2024-04-11 13:16:06 +02:00 committed by Fabian Grünbichler
parent 105d135e5a
commit da5a20c7c7
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PVE/QemuServer.pm
View File

@ -7381,6 +7381,7 @@ sub live_import_from_files {
mon_cmd($vmid, 'block-stream', mon_cmd($vmid, 'block-stream',
'job-id' => $job_id, 'job-id' => $job_id,
device => "drive-$ds", device => "drive-$ds",
'auto-dismiss' => JSON::false,
); );
$jobs->{$job_id} = {}; $jobs->{$job_id} = {};
} }