proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-06-15 11:29:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

virtiofs: drop writeback option

Browse Source 
VirtIO-fs using writeback cache seems very broken at the moment. If a
guest accesses a file (even just using 'touch'), that the host is
currently writing, the guest can permanently end up with a truncated
version of that file. Even subsequent operations like moving the file,
will not result in the correct file being visible, but just rename the
truncated one.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2025-04-08 17:07:14 +02:00 committed by Thomas Lamprecht
parent dfdd5c3689
commit d2d8a15dea
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
PVE/QemuServer/Virtiofs.pm
View File

@ -45,13 +45,6 @@ my $virtiofs_fmt = {
default => 0, default => 0,
optional => 1, optional => 1,
}, },
writeback => {
type => 'boolean',
description => "Enable writeback cache. If enabled, writes may be cached in the guest until"
." the file is closed or an fsync is performed.",
default => 0,
optional => 1,
},
'expose-xattr' => { 'expose-xattr' => {
type => 'boolean', type => 'boolean',
description => "Enable support for extended attributes for this mount.", description => "Enable support for extended attributes for this mount.",
@ -182,7 +175,6 @@ sub start_virtiofsd {
push @$cmd, '--announce-submounts'; push @$cmd, '--announce-submounts';
push @$cmd, '--allow-direct-io' if $virtiofs->{'direct-io'}; push @$cmd, '--allow-direct-io' if $virtiofs->{'direct-io'};
push @$cmd, '--cache='.$virtiofs->{cache} if $virtiofs->{cache}; push @$cmd, '--cache='.$virtiofs->{cache} if $virtiofs->{cache};
push @$cmd, '--writeback' if $virtiofs->{'writeback'};
push @$cmd, '--syslog'; push @$cmd, '--syslog';
exec(@$cmd); exec(@$cmd);
} elsif (!defined($pid2)) { } elsif (!defined($pid2)) {