proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-12-08 08:13:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #2408, #2355, #2380: use scsi-hd backend for iSCSI as well

Browse Source 
As mentioned in #2408, live-migrating a VM between storages that use
different scsi backends (scsi-hd, scsi-generic, scsi-block) breaks.

To fix, from QEMU 4.1 machine types onward (to not break current
behaviour any more), only use scsi-hd, as in recent versions, there is
almost no difference between the two anyway.

scsi-block (which potentially also breaks) requires a flag to be
manually set on the disk, so we can assume the user knows what they're
doing.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Suggested-by: Daniel Berteaud <daniel@firewall-services.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Stefan Reiter 2019-10-22 17:25:48 +02:00 committed by Thomas Lamprecht
parent 317c55c2d1
commit d1cbb1a93b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
PVE/QemuServer.pm
View File

@ -1898,7 +1898,8 @@ sub print_drivedevice_full {
$path = PVE::Storage::path($storecfg, $drive->{file}); $path = PVE::Storage::path($storecfg, $drive->{file});
} }
if($path =~ m/^iscsi\:\/\//){ if($path =~ m/^iscsi\:\/\// &&
!qemu_machine_feature_enabled($machine_type, undef, 4, 1)) {
$devicetype = 'generic'; $devicetype = 'generic';
} }
} }