proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-04 20:44:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qmp: use 'blockdev-change-medium' instead of generic 'change'

Browse Source 
...and cleanup surrounding code a bit.

'change' is deprecated, and according to the qapi definition in QEMU it
is 'strongly recommended' to avoid using it.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
This commit is contained in:
Stefan Reiter 2020-02-06 10:53:52 +01:00 committed by Thomas Lamprecht
parent 9e7bce2c88
commit ce9fce7985
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
PVE/QemuServer.pm
View File

@ -5137,8 +5137,14 @@ sub vmconfig_update_disk {
} }
} else { } else {
my $path = get_iso_path($storecfg, $vmid, $drive->{file}); my $path = get_iso_path($storecfg, $vmid, $drive->{file});
mon_cmd($vmid, "eject", force => JSON::true,device => "drive-$opt"); # force eject if locked
mon_cmd($vmid, "change", device => "drive-$opt",target => "$path") if $path; # force eject if locked
mon_cmd($vmid, "eject", force => JSON::true, device => "drive-$opt");
if ($path) {
mon_cmd($vmid, "blockdev-change-medium",
device => "drive-$opt", filename => "$path");
}
} }
return 1; return 1;