proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2026-01-26 22:13:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

improve 'pending changes' message for clone

Browse Source 
$newconf->{pending} is a reference to an empty hash, which is not falsy,
thus we always printed the warning

so check if there are actual values there and if yes,
give the names of the properties for which pending changes are found

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2018-09-12 10:53:52 +02:00 committed by Thomas Lamprecht
parent 91bba27165
commit c725dd5f92
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
PVE/API2/Qemu.pm
View File

@ -2785,8 +2785,9 @@ __PACKAGE__->register_method({
delete $newconf->{lock};
# do not write pending changes
if ($newconf->{pending}) {
warn "found pending changes, discarding for clone\n";
if (my @changes = keys %{$newconf->{pending}}) {
my $pending = join(',', @changes);
warn "found pending changes for '$pending', discarding for clone\n";
delete $newconf->{pending};
}