From c3d151080affe8b2d85ad9e1216ad28c09519014 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Fri, 13 Jan 2023 13:52:39 +0100
Subject: [PATCH] cdrom path: code reduction

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 PVE/QemuServer.pm | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6155f4da..f4b15fd2 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -19,6 +19,7 @@ use IO::Select;
 use IO::Socket::UNIX;
 use IPC::Open3;
 use JSON;
+use List::Util qw(first);
 use MIME::Base64;
 use POSIX;
 use Storable qw(dclone);
@@ -1289,13 +1290,9 @@ sub get_cdrom_path {
 
     return $cdrom_path if defined($cdrom_path);
 
-    if (-l "/dev/cdrom") {
-	$cdrom_path = "/dev/cdrom";
-    } elsif (-l "/dev/cdrom1") {
-	$cdrom_path = "/dev/cdrom1";
-    } elsif (-l "/dev/cdrom2") {
-	$cdrom_path = "/dev/cdrom2";
-    } else {
+    $cdrom_path = first { -l $_ } map { "/dev/cdrom$_" } ('', '1', '2');
+
+    if (!defined($cdrom_path)) {
 	log_warn("no physical CD-ROM available, ignoring");
 	$cdrom_path = '';
     }