proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-06-28 20:36:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix checks for transfering replication state/switching job target

Browse Source 
In some cases $self->{replicated_volumes} will be auto-vivified
to {} by checks like
next if $self->{replicated_volumes}->{$volid}
and then {} would evaluate to true in a boolean context.

Now the replication information is retrieved once in prepare,
and used to decide whether to make the calls or not.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Ebner 2020-10-29 14:31:31 +01:00 committed by Fabian Grünbichler
parent 68980d6626
commit c2c96d7378
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
PVE/QemuMigrate.pm
View File

@ -220,6 +220,10 @@ sub prepare {
# test if VM exists # test if VM exists
my $conf = $self->{vmconf} = PVE::QemuConfig->load_config($vmid); my $conf = $self->{vmconf} = PVE::QemuConfig->load_config($vmid);
my $repl_conf = PVE::ReplicationConfig->new();
$self->{replication_jobcfg} = $repl_conf->find_local_replication_job($vmid, $self->{node});
$self->{is_replicated} = $repl_conf->check_for_existing_jobs($vmid, 1);
PVE::QemuConfig->check_lock($conf); PVE::QemuConfig->check_lock($conf);
my $running = 0; my $running = 0;
@ -227,10 +231,7 @@ sub prepare {
die "can't migrate running VM without --online\n" if !$online; die "can't migrate running VM without --online\n" if !$online;
$running = $pid; $running = $pid;
my $repl_conf = PVE::ReplicationConfig->new(); if ($self->{is_replicated} && !$self->{replication_jobcfg}) {
my $is_replicated = $repl_conf->check_for_existing_jobs($vmid, 1);
my $is_replicated_to_target = defined($repl_conf->find_local_replication_job($vmid, $self->{node}));
if ($is_replicated && !$is_replicated_to_target) {
if ($self->{opts}->{force}) { if ($self->{opts}->{force}) {
$self->log('warn', "WARNING: Node '$self->{node}' is not a replication target. Existing " . $self->log('warn', "WARNING: Node '$self->{node}' is not a replication target. Existing " .
"replication jobs will fail after migration!\n"); "replication jobs will fail after migration!\n");
@ -362,9 +363,7 @@ sub sync_disks {
}); });
} }
my $rep_cfg = PVE::ReplicationConfig->new(); my $replicatable_volumes = !$self->{replication_jobcfg} ? {}
my $replication_jobcfg = $rep_cfg->find_local_replication_job($vmid, $self->{node});
my $replicatable_volumes = !$replication_jobcfg ? {}
: PVE::QemuConfig->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 1); : PVE::QemuConfig->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 1);
my $test_volid = sub { my $test_volid = sub {
@ -489,7 +488,7 @@ sub sync_disks {
} }
} }
if ($replication_jobcfg) { if ($self->{replication_jobcfg}) {
if ($self->{running}) { if ($self->{running}) {
my $version = PVE::QemuServer::kvm_user_version(); my $version = PVE::QemuServer::kvm_user_version();
@ -523,7 +522,7 @@ sub sync_disks {
my $start_time = time(); my $start_time = time();
my $logfunc = sub { $self->log('info', shift) }; my $logfunc = sub { $self->log('info', shift) };
$self->{replicated_volumes} = PVE::Replication::run_replication( $self->{replicated_volumes} = PVE::Replication::run_replication(
'PVE::QemuConfig', $replication_jobcfg, $start_time, $start_time, $logfunc); 'PVE::QemuConfig', $self->{replication_jobcfg}, $start_time, $start_time, $logfunc);
} }
# sizes in config have to be accurate for remote node to correctly # sizes in config have to be accurate for remote node to correctly
@ -1193,7 +1192,7 @@ sub phase3_cleanup {
} }
# transfer replication state before move config # transfer replication state before move config
$self->transfer_replication_state() if $self->{replicated_volumes}; $self->transfer_replication_state() if $self->{is_replicated};
# move config to remote node # move config to remote node
my $conffile = PVE::QemuConfig->config_file($vmid); my $conffile = PVE::QemuConfig->config_file($vmid);
@ -1202,7 +1201,7 @@ sub phase3_cleanup {
die "Failed to move config to node '$self->{node}' - rename failed: $!\n" die "Failed to move config to node '$self->{node}' - rename failed: $!\n"
if !rename($conffile, $newconffile); if !rename($conffile, $newconffile);
$self->switch_replication_job_target() if $self->{replicated_volumes}; $self->switch_replication_job_target() if $self->{is_replicated};
if ($self->{livemigration}) { if ($self->{livemigration}) {
if ($self->{stopnbd}) { if ($self->{stopnbd}) {