proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-01 11:11:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qemu_volume_snapshot_delete: drop (now) unused parameter

Browse Source 
since we always determine the deviceid, passing in a possibly wrong value makes
no sense and could actually re-introduce bugs.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2024-01-09 10:25:11 +01:00
parent c60586838a
commit c1b2092d5e
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
PVE/QemuConfig.pm
View File

@ -406,9 +406,8 @@ sub __snapshot_delete_vol_snapshot {
return if PVE::QemuServer::drive_is_cdrom($drive); return if PVE::QemuServer::drive_is_cdrom($drive);
my $storecfg = PVE::Storage::config(); my $storecfg = PVE::Storage::config();
my $volid = $drive->{file}; my $volid = $drive->{file};
my $device = "drive-$ds";
PVE::QemuServer::qemu_volume_snapshot_delete($vmid, $device, $storecfg, $volid, $snapname); PVE::QemuServer::qemu_volume_snapshot_delete($vmid, $storecfg, $volid, $snapname);
push @$unused, $volid; push @$unused, $volid;
} }

2
PVE/QemuServer.pm
View File

@ -4670,7 +4670,7 @@ sub qemu_volume_snapshot {
} }
sub qemu_volume_snapshot_delete { sub qemu_volume_snapshot_delete {
my ($vmid, $deviceid, $storecfg, $volid, $snap) = @_; my ($vmid, $storecfg, $volid, $snap) = @_;
my $running = check_running($vmid); my $running = check_running($vmid);
my $attached_deviceid; my $attached_deviceid;