proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-14 06:17:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

drive commandline: factor out determining direct cache usage into helper

Browse Source 
In preparation to re-use it for a check for live disk cloning.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2023-02-10 15:19:11 +01:00 committed by Thomas Lamprecht
parent eec9f9fe00
commit b7071d6c00
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
PVE/QemuServer.pm
View File

@ -1615,6 +1615,20 @@ my sub storage_allows_io_uring_default {
return 1;
}
my sub drive_uses_cache_direct {
my ($drive, $scfg) = @_;
my $cache_direct = 0;
if (my $cache = $drive->{cache}) {
$cache_direct = $cache =~ /^(?:off|none|directsync)$/;
} elsif (!drive_is_cdrom($drive) && !($scfg && $scfg->{type} eq 'btrfs' && !$scfg->{nocow})) {
$cache_direct = 1;
}
return $cache_direct;
}
sub print_drive_commandline_full {
my ($storecfg, $vmid, $drive, $pbs_name, $io_uring) = @_;
@ -1688,14 +1702,9 @@ sub print_drive_commandline_full {
$opts .= ",format=$format";
}
my $cache_direct = 0;
my $cache_direct = drive_uses_cache_direct($drive, $scfg);
if (my $cache = $drive->{cache}) {
$cache_direct = $cache =~ /^(?:off|none|directsync)$/;
} elsif (!drive_is_cdrom($drive) && !($scfg && $scfg->{type} eq 'btrfs' && !$scfg->{nocow})) {
$opts .= ",cache=none";
$cache_direct = 1;
}
$opts .= ",cache=none" if !$drive->{cache} && $cache_direct;
if (!$drive->{aio}) {
if ($io_uring && storage_allows_io_uring_default($scfg, $cache_direct)) {