proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-14 10:19:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

template: mark efidisk as read-only

Browse Source 
otherwise backups of templates using UEFI fail with storages like LVM
thin, where the volumes are not writable. disk controllers like IDE and
SATA that don't support being read-only are still broken for UEFI.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
[ drop the readonly=off when not required, resolve merger conflict
  from Dominik's EFI disk cache mode fix ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2021-06-04 11:47:45 +02:00 committed by Thomas Lamprecht
parent 75748d4492
commit b4dc647557
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
PVE/QemuServer.pm
View File

@ -3291,6 +3291,7 @@ sub config_to_command {
die "uefi base image '$ovmf_code' not found\n" if ! -f $ovmf_code; die "uefi base image '$ovmf_code' not found\n" if ! -f $ovmf_code;
my ($path, $format); my ($path, $format);
my $read_only_str = '';
if (my $efidisk = $conf->{efidisk0}) { if (my $efidisk = $conf->{efidisk0}) {
my $d = parse_drive('efidisk0', $efidisk); my $d = parse_drive('efidisk0', $efidisk);
my ($storeid, $volname) = PVE::Storage::parse_volume_id($d->{file}, 1); my ($storeid, $volname) = PVE::Storage::parse_volume_id($d->{file}, 1);
@ -3306,6 +3307,8 @@ sub config_to_command {
die "efidisk format must be specified\n" die "efidisk format must be specified\n"
if !defined($format); if !defined($format);
} }
$read_only_str = ',readonly=on' if drive_is_read_only($conf, $d);
} else { } else {
warn "no efidisk configured! Using temporary efivars disk.\n"; warn "no efidisk configured! Using temporary efivars disk.\n";
$path = "/tmp/$vmid-ovmf.fd"; $path = "/tmp/$vmid-ovmf.fd";
@ -3323,7 +3326,7 @@ sub config_to_command {
my $cache = $path =~ m/^rbd:/ ? ',cache=writeback' : ''; my $cache = $path =~ m/^rbd:/ ? ',cache=writeback' : '';
push @$cmd, '-drive', "if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code"; push @$cmd, '-drive', "if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code";
push @$cmd, '-drive', "if=pflash,unit=1$cache,format=$format,id=drive-efidisk0$size_str,file=$path"; push @$cmd, '-drive', "if=pflash,unit=1$cache,format=$format,id=drive-efidisk0$size_str,file=${path}${read_only_str}";
} }
# load q35 config # load q35 config