proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-29 05:53:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #5284: api: move-disk: assert content type support for target storage

Browse Source 
Asserts whether the target storage supports storing VM images before
moving a VM volume to the target storage.

Without the check in place, a VM volume can be moved to a storage, which
does not support VM images, but won't be able to start since any
attached volume must be stored on a supported storage.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
This commit is contained in:
Daniel Kral 2025-02-11 17:08:01 +01:00 committed by Fiona Ebner
parent 295d0be11c
commit b17e33788d
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
PVE/API2/Qemu.pm
View File

@ -4233,6 +4233,10 @@ __PACKAGE__->register_method({
die "you can't move to the same storage with same format\n" die "you can't move to the same storage with same format\n"
if $oldstoreid eq $storeid && (!$format || !$oldfmt || $oldfmt eq $format); if $oldstoreid eq $storeid && (!$format || !$oldfmt || $oldfmt eq $format);
my $scfg = PVE::Storage::storage_check_enabled($storecfg, $storeid);
raise_param_exc({ storage => "storage '$storeid' does not support vm images" })
if !$scfg->{content}->{images};
# this only checks snapshots because $disk is passed! # this only checks snapshots because $disk is passed!
my $snapshotted = PVE::QemuServer::Drive::is_volume_in_use( my $snapshotted = PVE::QemuServer::Drive::is_volume_in_use(
$storecfg, $storecfg,