mirror of
https://git.proxmox.com/git/qemu-server
synced 2025-10-04 21:14:21 +00:00
Fix guest agent shutdown without timeout
Regression from change allowing timeouts to be set, now shutting down
also works without timeouts again (previously qmp failed because of
the unknown "timeout" parameter passed to it).
We always delete the timeout value from the arguments, regardless of
truthiness. "delete" returns the deleted element, deleting a
non-existant hash entry returns undef, which is fine after this point:
"deleting non-existent elements returns the undefined value in their
corresponding positions."
- https://perldoc.perl.org/functions/delete.html
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
(cherry picked from commit 1688362d4e
)
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
This commit is contained in:
parent
ea65ab8fe2
commit
b08f11dd6b
@ -5460,9 +5460,8 @@ sub vm_qmp_command {
|
||||
my $res;
|
||||
|
||||
my $timeout;
|
||||
if ($cmd->{arguments} && $cmd->{arguments}->{timeout}) {
|
||||
$timeout = $cmd->{arguments}->{timeout};
|
||||
delete $cmd->{arguments}->{timeout};
|
||||
if ($cmd->{arguments}) {
|
||||
$timeout = delete $cmd->{arguments}->{timeout};
|
||||
}
|
||||
|
||||
eval {
|
||||
|
Loading…
Reference in New Issue
Block a user