proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-13 02:43:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix in PVE::QemuServer::snapshot_create

Browse Source 
remove the freezefs flag.
If Qemu Guest Agent flag is set in config the vm filesystem will always be frozen,
unless we save RAM.

also remove param freezefs in PVE::API2 snapshot,
because there is no use for it.

Signed-off-by: Wolfgang Link <wolfgang@linksystems.org>
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
This commit is contained in:
Wolfgang Link 2014-12-03 15:40:33 +01:00 committed by Dietmar Maurer
parent 108864e591
commit af9110ddd7
2 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
PVE/API2/Qemu.pm
View File

@ -2853,11 +2853,6 @@ __PACKAGE__->register_method({
type => 'boolean',
description => "Save the vmstate",
},
freezefs => {
optional => 1,
type => 'boolean',
description => "Freeze the filesystem",
},
description => {
optional => 1,
type => 'string',
@ -2887,8 +2882,8 @@ __PACKAGE__->register_method({
my $realcmd = sub {
PVE::Cluster::log_msg('info', $authuser, "snapshot VM $vmid: $snapname");
PVE::QemuServer::snapshot_create($vmid, $snapname, $param->{vmstate},
$param->{freezefs}, $param->{description});
PVE::QemuServer::snapshot_create($vmid, $snapname, $param->{vmstate},
$param->{description});
};
return $rpcenv->fork_worker('qmsnapshot', $vmid, $authuser, $realcmd);

19
PVE/QemuServer.pm
View File

@ -4876,19 +4876,22 @@ my $savevm_wait = sub {
};
sub snapshot_create {
my ($vmid, $snapname, $save_vmstate, $freezefs, $comment) = @_;
my ($vmid, $snapname, $save_vmstate, $comment) = @_;
my $snap = &$snapshot_prepare($vmid, $snapname, $save_vmstate, $comment);
$freezefs = $save_vmstate = 0 if !$snap->{vmstate}; # vm is not running
my $drivehash = {};
my $running = check_running($vmid);
$save_vmstate = 0 if !$snap->{vmstate}; # vm is not running
my $config = load_config($vmid);
if ($running && $freezefs && $config->{agent}) {
my $running = check_running($vmid);
my $freezefs = $running && $config->{agent};
$freezefs = 0 if $snap->{vmstate}; # not needed if we save RAM
my $drivehash = {};
if ($freezefs) {
eval { vm_mon_cmd($vmid, "guest-fsfreeze-freeze"); };
warn "guest-fsfreeze-freeze problems - $@" if $@;
}
@ -4926,7 +4929,7 @@ sub snapshot_create {
eval { vm_mon_cmd($vmid, "savevm-end") };
warn $@ if $@;
if ($freezefs && $config->{agent}) {
if ($freezefs) {
eval { vm_mon_cmd($vmid, "guest-fsfreeze-thaw"); };
warn "guest-fsfreeze-thaw problems - $@" if $@;
}