From acfc6ef8e060f8f92e9f1bdbd40169fb78b03202 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Thu, 5 Nov 2020 10:12:26 +0100 Subject: [PATCH] fix #3113: unbreak drive hotplug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit by adding the missing argument (otherwise all the other ones are shifted one slot to the left, which is of course bogus). this has been broken since 2018 (d559309), but was only made visible/caused a failure with the recent changes adding use strict; use warnings; to PVE::QemuServer::PCI Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a2824490..fb68ce57 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3719,7 +3719,7 @@ sub vm_deviceplug { qemu_iothread_add($vmid, $deviceid, $device); qemu_driveadd($storecfg, $vmid, $device); - my $devicefull = print_drivedevice_full($storecfg, $conf, $vmid, $device, $arch, $machine_type); + my $devicefull = print_drivedevice_full($storecfg, $conf, $vmid, $device, undef, $arch, $machine_type); qemu_deviceadd($vmid, $devicefull); eval { qemu_deviceaddverify($vmid, $deviceid); }; @@ -3755,7 +3755,7 @@ sub vm_deviceplug { qemu_findorcreatescsihw($storecfg,$conf, $vmid, $device, $arch, $machine_type); qemu_driveadd($storecfg, $vmid, $device); - my $devicefull = print_drivedevice_full($storecfg, $conf, $vmid, $device, $arch, $machine_type); + my $devicefull = print_drivedevice_full($storecfg, $conf, $vmid, $device, undef, $arch, $machine_type); eval { qemu_deviceadd($vmid, $devicefull); }; if (my $err = $@) { eval { qemu_drivedel($vmid, $deviceid); };