From ab5b97d8a814abdcb9d4bef4d6de442bd0fb1cdb Mon Sep 17 00:00:00 2001 From: Fabian Ebner Date: Mon, 19 Apr 2021 15:39:50 +0200 Subject: [PATCH] drive: volume in-use check: remove unused closure parameter and simplify the calling iteration. Suggested-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- PVE/QemuServer/Drive.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm index 9016a43e..0d66b2ec 100644 --- a/PVE/QemuServer/Drive.pm +++ b/PVE/QemuServer/Drive.pm @@ -574,7 +574,7 @@ sub is_volume_in_use { my $path = PVE::Storage::path($storecfg, $volid); my $scan_config = sub { - my ($cref, $snapname) = @_; + my ($cref) = @_; foreach my $key (keys %$cref) { my $value = $cref->{$key}; @@ -602,8 +602,8 @@ sub is_volume_in_use { undef $skip_drive; - foreach my $snapname (keys %{$conf->{snapshots}}) { - return 1 if &$scan_config($conf->{snapshots}->{$snapname}, $snapname); + for my $snap (values %{$conf->{snapshots}}) { + return 1 if $scan_config->($snap); } return 0;