proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-10-04 19:20:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #2728: die/warn if target is not a replication target when live-migrating

Browse Source 
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
This commit is contained in:
Fabian Ebner 2020-05-18 09:37:57 +02:00 committed by Fabian Grünbichler
parent 503e96f8de
commit aa491a6ecd
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
PVE/API2/Qemu.pm
View File

@ -3535,6 +3535,19 @@ __PACKAGE__->register_method({
if (PVE::QemuServer::check_running($vmid)) { if (PVE::QemuServer::check_running($vmid)) {
die "can't migrate running VM without --online\n" if !$param->{online}; die "can't migrate running VM without --online\n" if !$param->{online};
my $repl_conf = PVE::ReplicationConfig->new();
my $is_replicated = $repl_conf->check_for_existing_jobs($vmid, 1);
my $is_replicated_to_target = defined($repl_conf->find_local_replication_job($vmid, $target));
if ($is_replicated && !$is_replicated_to_target) {
if ($param->{force}) {
warn "WARNING: Node '$target' is not a replication target. Existing replication " .
"jobs will fail after migration!\n";
} else {
die "Cannot live-migrate replicated VM to node '$target' - not a replication target." .
" Use 'force' to override.\n";
}
}
} else { } else {
warn "VM isn't running. Doing offline migration instead.\n" if $param->{online}; warn "VM isn't running. Doing offline migration instead.\n" if $param->{online};
$param->{online} = 0; $param->{online} = 0;