proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-29 16:38:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

clone disk: add version guard for qemu-img dd's -l option

Browse Source 
It's only available since QEMU 6.2 and doing a check here rather than
bumping the package dependency allows for easy downgrades.

Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Ebner 2022-04-05 10:22:14 +02:00 committed by Thomas Lamprecht
parent 3e7d9fac7c
commit a9c45bd4a4
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
PVE/QemuServer.pm
View File

@ -7708,7 +7708,12 @@ sub clone_disk {
my $bs = 1024*1024;
my $cmd = ['qemu-img', 'dd', '-n', '-O', $dst_format];
push $cmd->@*, '-l', $snapname if $src_format eq 'qcow2' && $snapname;
if ($src_format eq 'qcow2' && $snapname) {
die "cannot clone qcow2 EFI disk snapshot - requires QEMU >= 6.2\n"
if !min_version(kvm_user_version(), 6, 2);
push $cmd->@*, '-l', $snapname;
}
push $cmd->@*, "bs=$bs", "osize=$size", "if=$src_path", "of=$dst_path";
run_command($cmd);
} else {