From a55d0f71b2bc5484611312167384539a387e9c69 Mon Sep 17 00:00:00 2001 From: Filip Schauer Date: Thu, 10 Aug 2023 11:20:36 +0200 Subject: [PATCH] fix #3963: Skip TPM startup for template VMs Skip the software TPM startup when starting a template VM for performing a backup. This fixes an error that occurs when the TPM state disk is write-protected. Signed-off-by: Filip Schauer --- PVE/QemuServer.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 484bc7f2..bf1de179 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3823,7 +3823,9 @@ sub config_to_command { push @$devices, @$audio_devs; } - add_tpm_device($vmid, $devices, $conf); + # Add a TPM only if the VM is not a template, + # to support backing up template VMs even if the TPM disk is write-protected. + add_tpm_device($vmid, $devices, $conf) if (!PVE::QemuConfig->is_template($conf)); my $sockets = 1; $sockets = $conf->{smp} if $conf->{smp}; # old style - no longer iused @@ -5923,7 +5925,7 @@ sub vm_start_nolock { PVE::Systemd::enter_systemd_scope($vmid, "Proxmox VE VM $vmid", %systemd_properties); my $tpmpid; - if (my $tpm = $conf->{tpmstate0}) { + if ((my $tpm = $conf->{tpmstate0}) && !PVE::QemuConfig->is_template($conf)) { # start the TPM emulator so QEMU can connect on start $tpmpid = start_swtpm($storecfg, $vmid, $tpm, $migratedfrom); }