proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-13 20:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

gen_rand_chars: handle errors properly

Browse Source 
should not really happen on modern systems, but random_bytes just
returns false if it fails to generate random bytes, in which case we
want to die instead of returning an empty 'random' string.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2020-06-22 12:03:01 +02:00
parent 3c5bdde815
commit a4e128a9a9
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
PVE/API2/Qemu.pm
View File

@ -1597,8 +1597,12 @@ my $gen_rand_chars = sub {
die "invalid length $length" if $length < 1;
my $min = ord('!'); # first printable ascii
my @rand_bytes = split '', Crypt::OpenSSL::Random::random_bytes($length);
my $str = join('', map { chr((ord($_) & 0x3F) + $min) } @rand_bytes);
my $rand_bytes = Crypt::OpenSSL::Random::random_bytes($length);
die "failed to generate random bytes!\n"
if !$rand_bytes;
my $str = join('', map { chr((ord($_) & 0x3F) + $min) } split('', $rand_bytes));
return $str;
};