proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-29 22:43:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

migrate: factor out storage checks

Browse Source 
to re-use them for incoming remote migrations.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2021-11-05 14:03:52 +01:00 committed by Thomas Lamprecht
parent a4d828e35e
commit 9fb295d095
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
PVE/API2/Qemu.pm
View File

@ -135,6 +135,18 @@ my $check_storage_access_clone = sub {
return $sharedvm; return $sharedvm;
}; };
my $check_storage_access_migrate = sub {
my ($rpcenv, $authuser, $storecfg, $storage, $node) = @_;
PVE::Storage::storage_check_enabled($storecfg, $storage, $node);
$rpcenv->check($authuser, "/storage/$storage", ['Datastore.AllocateSpace']);
my $scfg = PVE::Storage::storage_config($storecfg, $storage);
die "storage '$storage' does not support vm images\n"
if !$scfg->{content}->{images};
};
# Note: $pool is only needed when creating a VM, because pool permissions # Note: $pool is only needed when creating a VM, because pool permissions
# are automatically inherited if VM already exists inside a pool. # are automatically inherited if VM already exists inside a pool.
my $create_disks = sub { my $create_disks = sub {
@ -3925,17 +3937,7 @@ __PACKAGE__->register_method({
} }
my $storecfg = PVE::Storage::config(); my $storecfg = PVE::Storage::config();
if (my $targetstorage = $param->{targetstorage}) { if (my $targetstorage = $param->{targetstorage}) {
my $check_storage = sub {
my ($target_sid) = @_;
PVE::Storage::storage_check_enabled($storecfg, $target_sid, $target);
$rpcenv->check($authuser, "/storage/$target_sid", ['Datastore.AllocateSpace']);
my $scfg = PVE::Storage::storage_config($storecfg, $target_sid);
raise_param_exc({ targetstorage => "storage '$target_sid' does not support vm images"})
if !$scfg->{content}->{images};
};
my $storagemap = eval { PVE::JSONSchema::parse_idmap($targetstorage, 'pve-storage-id') }; my $storagemap = eval { PVE::JSONSchema::parse_idmap($targetstorage, 'pve-storage-id') };
raise_param_exc({ targetstorage => "failed to parse storage map: $@" }) raise_param_exc({ targetstorage => "failed to parse storage map: $@" })
if $@; if $@;
@ -3944,10 +3946,10 @@ __PACKAGE__->register_method({
if !defined($storagemap->{identity}); if !defined($storagemap->{identity});
foreach my $target_sid (values %{$storagemap->{entries}}) { foreach my $target_sid (values %{$storagemap->{entries}}) {
$check_storage->($target_sid); $check_storage_access_migrate->($rpcenv, $authuser, $storecfg, $target_sid, $target);
} }
$check_storage->($storagemap->{default}) $check_storage_access_migrate->($rpcenv, $authuser, $storecfg, $storagemap->{default}, $target)
if $storagemap->{default}; if $storagemap->{default};
PVE::QemuServer::check_storage_availability($storecfg, $conf, $target) PVE::QemuServer::check_storage_availability($storecfg, $conf, $target)