From 9a8d6b6665d8d64fa8da499694cbb597f7cd0fe2 Mon Sep 17 00:00:00 2001 From: Alexandre Derumier Date: Tue, 19 Feb 2013 10:22:11 +0100 Subject: [PATCH] hot-unplug : add some warnings for differents guest os Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 71d39a90..daada76c 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -646,8 +646,17 @@ my $vmconfig_delete_option = sub { $rpcenv->check($authuser, "/storage/$sid", ['Datastore.Allocate']); } } - - die "error hot-unplug $opt" if !PVE::QemuServer::vm_deviceunplug($vmid, $conf, $opt); + + my $unplugwarning = ""; + if($conf->{ostype} && $conf->{ostype} eq 'l26'){ + $unplugwarning = "
verify that you have acpiphp && pci_hotplug modules loaded in your guest VM"; + }elsif($conf->{ostype} && $conf->{ostype} eq 'l24'){ + $unplugwarning = "
kernel 2.4 don't support hotplug, please disable hotplug in options"; + }elsif(!$conf->{ostype} || ($conf->{ostype} && $conf->{ostype} eq 'other')){ + $unplugwarning = "
verify that your guest support acpi hotplug"; + } + + die "error hot-unplug $opt $unplugwarning" if !PVE::QemuServer::vm_deviceunplug($vmid, $conf, $opt); PVE::QemuServer::vm_deviceplug(undef, $conf, $vmid, $opt) if $opt eq 'tablet';