proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-04-29 18:34:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cloudinit: allow non-root users to set ciupgrade option

Browse Source 
The new ciupgrade option was missing in $cloudinitoptions in
PVE::API2::Qemu, so $check_vm_modify_config_perm defaulted to
requiring root@pam for modifying the option. To fix this, add
ciupgrade to $cloudinitoptions. This also fixes an issue where
ciupgrade was missing in the output of `qm cloudinit pending`,
as it also relies on $cloudinitoptions.

This issue was originally reported in the forum [0].

Also add a comment to avoid similar issues when adding new options in
the future.

[0]: https://forum.proxmox.com/threads/131043/

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
This commit is contained in:
Friedrich Weber 2023-07-24 13:33:48 +02:00 committed by Thomas Lamprecht
parent b155086bd8
commit 92c02f6c64
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PVE/API2/Qemu.pm
View File

@ -562,6 +562,7 @@ my $cloudinitoptions = {
cipassword => 1, cipassword => 1,
citype => 1, citype => 1,
ciuser => 1, ciuser => 1,
ciupgrade => 1,
nameserver => 1, nameserver => 1,
searchdomain => 1, searchdomain => 1,
sshkeys => 1, sshkeys => 1,

1
PVE/QemuServer.pm
View File

@ -760,6 +760,7 @@ my $cicustom_fmt = {
}; };
PVE::JSONSchema::register_format('pve-qm-cicustom', $cicustom_fmt); PVE::JSONSchema::register_format('pve-qm-cicustom', $cicustom_fmt);
# any new option might need to be added to $cloudinitoptions in PVE::API2::Qemu
my $confdesc_cloudinit = { my $confdesc_cloudinit = {
citype => { citype => {
optional => 1, optional => 1,