From 86b1f1c24c2ec66881ceb753ef5231ed4173a9d5 Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Tue, 23 Jul 2024 17:25:44 +0200 Subject: [PATCH] cfg2cmd: require at least QEMU binary version 5.0 The minimum supported version for a Proxmox VE 8 node is QEMU 8.0. Signed-off-by: Fiona Ebner Reviewed-by: Daniel Kral Tested-by: Daniel Kral --- PVE/QemuServer.pm | 4 ++-- test/cfg2cmd/old-qemu.conf | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 320cada0..e2c073d1 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3614,9 +3614,9 @@ sub config_to_command { my $kvm_binary = get_command_for_arch($arch); my $kvmver = kvm_user_version($kvm_binary); - if (!$kvmver || $kvmver !~ m/^(\d+)\.(\d+)/ || $1 < 4) { + if (!$kvmver || $kvmver !~ m/^(\d+)\.(\d+)/ || $1 < 5) { $kvmver //= "undefined"; - die "Detected old QEMU binary ('$kvmver', at least 4.0 is required)\n"; + die "Detected old QEMU binary ('$kvmver', at least 5.0 is required)\n"; } my $add_pve_version = min_version($kvmver, 4, 1); diff --git a/test/cfg2cmd/old-qemu.conf b/test/cfg2cmd/old-qemu.conf index 14489a3b..e8129cf6 100644 --- a/test/cfg2cmd/old-qemu.conf +++ b/test/cfg2cmd/old-qemu.conf @@ -1,4 +1,4 @@ # TEST: Test QEMU version detection and expect fail on old version -# QEMU_VERSION: 3.0.1 -# EXPECT_ERROR: Detected old QEMU binary ('3.0.1', at least 4.0 is required) +# QEMU_VERSION: 4.0.1 +# EXPECT_ERROR: Detected old QEMU binary ('4.0.1', at least 5.0 is required) smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465