From 84c253e94709c1eaa6013730f5cbccdd16a5e9a5 Mon Sep 17 00:00:00 2001 From: Fabian Ebner Date: Wed, 9 Mar 2022 11:09:12 +0100 Subject: [PATCH] parse ovf: untaint path when calling file_size_info Prepare for calling parse_ovf via API, where the -T switch is used. Signed-off-by: Fabian Ebner --- PVE/QemuServer/OVF.pm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm index 0376cbf5..b97b0520 100644 --- a/PVE/QemuServer/OVF.pm +++ b/PVE/QemuServer/OVF.pm @@ -221,10 +221,11 @@ ovf:Item[rasd:InstanceID='%s']/rasd:ResourceType", $controller_id); die "error parsing $filepath, file seems not to exist at $backing_file_path\n"; } - my $virtual_size; - if ( !($virtual_size = PVE::Storage::file_size_info($backing_file_path)) ) { - die "error parsing $backing_file_path, size seems to be $virtual_size\n"; - } + ($backing_file_path) = $backing_file_path =~ m|^(/.*)|; # untaint + + my $virtual_size = PVE::Storage::file_size_info($backing_file_path); + die "error parsing $backing_file_path, cannot determine file size\n" + if !$virtual_size; $pve_disk = { disk_address => $pve_disk_address,