proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-03 08:20:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

t/cfg2cmd: ensure tests can pass again

Browse Source 
the change to use a real diff to check tests, with it's nicer output
for failing cases, failed to ensure that the test system knew if a
case passed - earlier done indirectly by 'is_deeply', thus add a
manual 'pass' call if the tes was OK.
Further, the firs test failing aborted everything, which isn't to
nice, normally it's much more convenient if all test get run and one
can view at the results of all of them. So put the diff in an eval
and fail/note the test manually.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Acked-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2018-12-10 18:00:03 +01:00 committed by Wolfgang Bumiller
parent 3dc780c643
commit 8256220068
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/run_config2command_tests.pl
View File

@ -190,7 +190,13 @@ sub do_test($) {
my $exp = join("\n", @$cmd_expected);
my $got = join("\n", @$cmd);
diff($exp, $got);
eval { diff($exp, $got) };
if (my $err = $@) {
fail("$testname");
note($err);
} else {
pass("$testname");
}
} else {
file_set_contents($cmd_fn, $cmdline);
}