From 79046fd12e1ec906c8fce5aeee8bb9f142f4fc36 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Thu, 28 Feb 2019 09:15:59 +0100 Subject: [PATCH] fix #2114: set correct link status on hotplug we also need to set the link status if the whole device changed, otherwise a change of macaddress allows a network connection even if link_down is set to 1 Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6e56eda4..54222966 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4140,7 +4140,10 @@ sub vm_deviceplug { my $netdevicefull = print_netdevice_full($vmid, $conf, $device, $deviceid, undef, $use_old_bios_files, $arch, $machine_type); qemu_deviceadd($vmid, $netdevicefull); - eval { qemu_deviceaddverify($vmid, $deviceid); }; + eval { + qemu_deviceaddverify($vmid, $deviceid); + qemu_set_link_status($vmid, $deviceid, !$device->{link_down}); + }; if (my $err = $@) { eval { qemu_netdevdel($vmid, $deviceid); }; warn $@ if $@;