From 742da46a44f7d882620ae0d8d8cc08ab7b3f8dcc Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Mon, 10 Jul 2023 10:53:02 +0200 Subject: [PATCH] qmeventd: VMID from PID: avoid goto If strtol() returns an errno, make sure not to print the error message twice after the refactoring. Signed-off-by: Fiona Ebner --- qmeventd/qmeventd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c index 76a894cb..002b2ac4 100644 --- a/qmeventd/qmeventd.c +++ b/qmeventd/qmeventd.c @@ -134,20 +134,18 @@ get_vmid_from_pid(pid_t pid) continue; } if (errno != 0) { - fprintf(stderr, "error parsing vmid for %d: %s\n", pid, strerror(errno)); vmid = 0; } - goto ret; + break; } if (errno) { fprintf(stderr, "error parsing vmid for %d: %s\n", pid, strerror(errno)); - } else { + } else if (!vmid) { fprintf(stderr, "error parsing vmid for %d: no matching qemu.slice cgroup entry\n", pid); } -ret: free(buf); fclose(fp); return vmid;