From 6ca8b698708b3dbe8706bdc323f1becb2d824827 Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Mon, 17 Nov 2014 09:37:11 +0100 Subject: [PATCH] fix balloon consistency check (consider pending changes) Signed-off-by: Dietmar Maurer --- PVE/API2/Qemu.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 407674c8..01821500 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -945,10 +945,9 @@ my $update_vm_api = sub { PVE::QemuServer::check_lock($conf) if !$skiplock; - # fixme: wrong place? howto handle pending changes? @delete ? if ($param->{memory} || defined($param->{balloon})) { - my $maxmem = $param->{memory} || $conf->{memory} || $defaults->{memory}; - my $balloon = defined($param->{balloon}) ? $param->{balloon} : $conf->{balloon}; + my $maxmem = $param->{memory} || $conf->{pending}->{memory} || $conf->{memory} || $defaults->{memory}; + my $balloon = defined($param->{balloon}) ? $param->{balloon} : $conf->{pending}->{balloon} || $conf->{balloon}; die "balloon value too large (must be smaller than assigned memory)\n" if $balloon && $balloon > $maxmem;