proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-05 10:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qmp: use query-cpus-fast for hotplug

Browse Source 
query-cpus has been deprecated since 2.12.0 [0] in favor of
query-cpus-fast, which no longer incurs a guest performance penalty on
the guest. The returned information is the same as far as our use case
is concerned.

[0] https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
This commit is contained in:
Stefan Reiter 2020-02-06 10:53:55 +01:00 committed by Thomas Lamprecht
parent 485449e37b
commit 65af8c312e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
PVE/QemuServer.pm
View File

@ -4504,7 +4504,7 @@ sub qemu_cpu_hotplug {
my $retry = 0; my $retry = 0;
my $currentrunningvcpus = undef; my $currentrunningvcpus = undef;
while (1) { while (1) {
$currentrunningvcpus = mon_cmd($vmid, "query-cpus"); $currentrunningvcpus = mon_cmd($vmid, "query-cpus-fast");
last if scalar(@{$currentrunningvcpus}) == $i-1; last if scalar(@{$currentrunningvcpus}) == $i-1;
raise_param_exc({ vcpus => "error unplugging cpu$i" }) if $retry > 5; raise_param_exc({ vcpus => "error unplugging cpu$i" }) if $retry > 5;
$retry++; $retry++;
@ -4521,7 +4521,7 @@ sub qemu_cpu_hotplug {
return; return;
} }
my $currentrunningvcpus = mon_cmd($vmid, "query-cpus"); my $currentrunningvcpus = mon_cmd($vmid, "query-cpus-fast");
die "vcpus in running vm does not match its configuration\n" die "vcpus in running vm does not match its configuration\n"
if scalar(@{$currentrunningvcpus}) != $currentvcpus; if scalar(@{$currentrunningvcpus}) != $currentvcpus;
@ -4534,7 +4534,7 @@ sub qemu_cpu_hotplug {
my $retry = 0; my $retry = 0;
my $currentrunningvcpus = undef; my $currentrunningvcpus = undef;
while (1) { while (1) {
$currentrunningvcpus = mon_cmd($vmid, "query-cpus"); $currentrunningvcpus = mon_cmd($vmid, "query-cpus-fast");
last if scalar(@{$currentrunningvcpus}) == $i; last if scalar(@{$currentrunningvcpus}) == $i;
raise_param_exc({ vcpus => "error hotplugging cpu$i" }) if $retry > 10; raise_param_exc({ vcpus => "error hotplugging cpu$i" }) if $retry > 10;
sleep 1; sleep 1;