proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2026-01-03 21:07:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #3886: QEMU restore: verify storage allows images before writing

Browse Source 
When restoring a backup and the storage the disks would be created on
doesn't allow 'images', the process errors without cleanup.
This is the same behaviour we currently have when the storage is
disabled.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Matthias Heiserer 2022-02-24 11:45:59 +01:00 committed by Thomas Lamprecht
parent 5f5aba2578
commit 62af60cd3d
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
PVE/QemuServer.pm
View File

@ -6249,6 +6249,10 @@ my $parse_backup_hints = sub {
$devinfo->{$devname}->{format} = $format;
$devinfo->{$devname}->{storeid} = $storeid;
my $scfg = PVE::Storage::storage_config($storecfg, $storeid);
die "Content type 'images' is not available on storage '$storeid'\n"
if !$scfg->{content}->{images};
# check permission on storage
my $pool = $options->{pool}; # todo: do we need that?
if ($user ne 'root@pam') {
@ -6265,6 +6269,9 @@ my $parse_backup_hints = sub {
my $scfg = PVE::Storage::storage_config($storecfg, $storeid);
my $format = qemu_img_format($scfg, $volname); # has 'raw' fallback
die "Content type 'images' is not available on storage '$storeid'\n"
if !$scfg->{content}->{images};
$virtdev_hash->{$virtdev} = {
format => $format,
storeid => $storeid,