proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-03 10:29:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

clone disk: assert that drive name is the same for drive-mirror on single VM

Browse Source 
because when the VM ID of target and source are the same,
qemu_drive_mirror_monitor() switches the QEMU device node over to the
new backing image. The planned import-from functionality makes it
possible to run into this, although for an a bit unusual use case.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Ebner 2022-03-17 12:30:59 +01:00 committed by Fabian Grünbichler
parent f9be9137fc
commit 5f9575929a
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
PVE/QemuServer.pm
View File

@ -7585,11 +7585,17 @@ sub clone_disk {
my ($newvmid, $dst_drivename, $efisize) = $dest->@{qw(vmid drivename efisize)}; my ($newvmid, $dst_drivename, $efisize) = $dest->@{qw(vmid drivename efisize)};
my ($storage, $format) = $dest->@{qw(storage format)}; my ($storage, $format) = $dest->@{qw(storage format)};
my $use_drive_mirror = $full && $running && $src_drivename && !$snapname;
if ($src_drivename && $dst_drivename && $src_drivename ne $dst_drivename) { if ($src_drivename && $dst_drivename && $src_drivename ne $dst_drivename) {
die "cloning from/to EFI disk requires EFI disk\n" die "cloning from/to EFI disk requires EFI disk\n"
if $src_drivename eq 'efidisk0' || $dst_drivename eq 'efidisk0'; if $src_drivename eq 'efidisk0' || $dst_drivename eq 'efidisk0';
die "cloning from/to TPM state requires TPM state\n" die "cloning from/to TPM state requires TPM state\n"
if $src_drivename eq 'tpmstate0' || $dst_drivename eq 'tpmstate0'; if $src_drivename eq 'tpmstate0' || $dst_drivename eq 'tpmstate0';
# This would lead to two device nodes in QEMU pointing to the same backing image!
die "cannot change drive name when cloning disk from/to the same VM\n"
if $use_drive_mirror && $vmid == $newvmid;
} }
my $newvolid; my $newvolid;
@ -7644,7 +7650,12 @@ sub clone_disk {
} }
my $sparseinit = PVE::Storage::volume_has_feature($storecfg, 'sparseinit', $newvolid); my $sparseinit = PVE::Storage::volume_has_feature($storecfg, 'sparseinit', $newvolid);
if (!$running || !$src_drivename || $snapname) { if ($use_drive_mirror) {
die "cannot move TPM state while VM is running\n" if $src_drivename eq 'tpmstate0';
qemu_drive_mirror($vmid, $src_drivename, $newvolid, $newvmid, $sparseinit, $jobs,
$completion, $qga, $bwlimit);
} else {
# TODO: handle bwlimits # TODO: handle bwlimits
if ($dst_drivename eq 'efidisk0') { if ($dst_drivename eq 'efidisk0') {
# the relevant data on the efidisk may be smaller than the source # the relevant data on the efidisk may be smaller than the source
@ -7661,11 +7672,6 @@ sub clone_disk {
} else { } else {
qemu_img_convert($drive->{file}, $newvolid, $size, $snapname, $sparseinit); qemu_img_convert($drive->{file}, $newvolid, $size, $snapname, $sparseinit);
} }
} else {
die "cannot move TPM state while VM is running\n" if $src_drivename eq 'tpmstate0';
qemu_drive_mirror($vmid, $src_drivename, $newvolid, $newvmid, $sparseinit, $jobs,
$completion, $qga, $bwlimit);
} }
} }