proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2026-01-07 00:06:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

move template checks up one level

Browse Source 
To avoid multiple/repeated calls to load_config().
This commit is contained in:
Dietmar Maurer 2013-02-15 08:04:30 +01:00
parent f78fe36ece
commit 5295b23dfb
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
PVE/QemuServer.pm
View File

@ -2886,10 +2886,6 @@ sub qemu_block_resize {
sub qemu_volume_snapshot {
my ($vmid, $deviceid, $storecfg, $volid, $snap) = @_;
my $conf = PVE::QemuServer::load_config($vmid);
die "you can't take a snapshot if it's a template" if is_template($conf);
my $running = check_running($vmid);
return if !PVE::Storage::volume_snapshot($storecfg, $volid, $snap, $running);
@ -2903,10 +2899,6 @@ sub qemu_volume_snapshot {
sub qemu_volume_snapshot_delete {
my ($vmid, $deviceid, $storecfg, $volid, $snap) = @_;
my $conf = PVE::QemuServer::load_config($vmid);
die "you can't delete a snapshot if vm is a template" if is_template($conf);
my $running = check_running($vmid);
return if !PVE::Storage::volume_snapshot_delete($storecfg, $volid, $snap, $running);
@ -4098,6 +4090,9 @@ my $snapshot_prepare = sub {
my $conf = load_config($vmid);
die "you can't take a snapshot if it's a template"
if is_template($conf);
check_lock($conf);
$conf->{lock} = 'snapshot';
@ -4328,7 +4323,11 @@ sub snapshot_delete {
my $conf = load_config($vmid);
check_lock($conf) if !$drivehash;
if (!$drivehash) {
check_lock($conf);
die "you can't delete a snapshot if vm is a template"
if is_template($conf);
}
$snap = $conf->{snapshots}->{$snapname};