From 4b0269379b2cd06ca7a0643bc89e271a128c3ee3 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 8 Nov 2019 15:02:50 +0100 Subject: [PATCH] followup: make comment a bit shorter/more concise Signed-off-by: Thomas Lamprecht --- PVE/QemuServer.pm | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f9b5242f..926ac93c 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6605,12 +6605,9 @@ sub restore_tar_archive { my $storecfg = PVE::Storage::config(); - # Restoring a backup can replace an existing VM. In this case, we need to - # remove existing data such as disks as they would pile up as unused disks - # in the new VM otherwise. - # keep_empty_config=1 to prevent races until overwriting it with the - # restored config. - # skiplock=1 because qmrestore has set the lock itself. + # avoid zombie disks when restoring over an existing VM -> cleanup first + # pass keep_empty_config=1 to keep the config (thus VMID) reserved for us + # skiplock=1 because qmrestore has set the 'create' lock itself already my $vmcfgfn = PVE::QemuConfig->config_file($vmid); destroy_vm($storecfg, $vmid, 1, 1) if -f $vmcfgfn;