From 4a5cb613d37b684133d73f70a205e8df096513ce Mon Sep 17 00:00:00 2001 From: Alexandre Derumier Date: Tue, 6 Jul 2021 00:02:30 +0200 Subject: [PATCH] api2: fix vmconfig_apply_pending errors handling commit https://git.proxmox.com/?p=qemu-server.git;a=commit;h=eb5e482ded9ae6aeb6575de9441b79b90a5de531 have introduced error handling for offline pending apply, - PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $storecfg, $running); + PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $storecfg, $running, $errors); sub vmconfig_apply_pending { - my ($vmid, $conf, $storecfg) = @_; + my ($vmid, $conf, $storecfg, $errors) = @_; but they was wrong nonused $running param, so currently $errors are not correctly handled Fixes: eb5e482ded ("vmconfig_apply_pending: add error handling") Signed-off-by: Alexandre Derumier Tested-by: Oguz Bektas --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 1e540f58..f2557e32 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1413,7 +1413,7 @@ my $update_vm_api = sub { if ($running) { PVE::QemuServer::vmconfig_hotplug_pending($vmid, $conf, $storecfg, $modified, $errors); } else { - PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $storecfg, $running, $errors); + PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $storecfg, $errors); } raise_param_exc($errors) if scalar(keys %$errors);