proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-04-28 13:30:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

backup: future-proof checks for QEMU feature support

Browse Source 
The features returned by the 'query-proxmox-support' QMP command are
booleans, so just checking for definedness is not enough in principle.
In practice, a feature is currently always true if defined. Still, fix
the checks, should the need to disable support for a feature ever
arise in the future and to avoid propagating the pattern further.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Reviewed-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Link: https://lore.proxmox.com/20250404133204.239783-19-f.ebner@proxmox.com
This commit is contained in:
Fiona Ebner 2025-04-04 15:31:53 +02:00 committed by Thomas Lamprecht
parent cc4a8b81ce
commit 3ce3c029e0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
PVE/VZDump/QemuServer.pm
View File

@ -639,7 +639,7 @@ my sub check_and_prepare_fleecing {
my $use_fleecing = $fleecing_opts && $fleecing_opts->{enabled} && !$is_template;
if ($use_fleecing && !defined($qemu_support->{'backup-fleecing'})) {
if ($use_fleecing && !$qemu_support->{'backup-fleecing'}) {
$self->log(
'warn',
"running QEMU version does not support backup fleecing - continuing without",
@ -739,7 +739,7 @@ sub archive_pbs {
# pve-qemu supports it since 5.2.0-1 (PVE 6.4), so safe to die since PVE 8
die "master key configured but running QEMU version does not support master keys\n"
if !defined($qemu_support->{'pbs-masterkey'}) && defined($master_keyfile);
if !$qemu_support->{'pbs-masterkey'} && defined($master_keyfile);
$attach_tpmstate_drive->($self, $task, $vmid);