proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-14 05:52:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add check for snapshots at migration

Browse Source 
We cannot migrate snapshots on local disks, for example lvmthin snapshots.
This commit is contained in:
Dietmar Maurer 2016-06-16 10:21:57 +02:00
parent c4d2d6c15c
commit 3629c19d23
1 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
PVE/QemuMigrate.pm
View File

@ -248,9 +248,9 @@ sub sync_disks {
}); });
} }
# and add used, owned/non-shared disks (just to be sure we have all) my $snapname;
PVE::QemuServer::foreach_volid($conf, sub { my $test_volid = sub {
my ($volid, $is_cdrom) = @_; my ($volid, $is_cdrom) = @_;
return if !$volid; return if !$volid;
@ -271,17 +271,37 @@ sub sync_disks {
return if $scfg->{shared}; return if $scfg->{shared};
die "can't migrate local cdrom '$volid'\n" if $cdromhash->{$volid};
$sharedvm = 0; $sharedvm = 0;
die "can't migrate local cdrom '$volid'\n" if $cdromhash->{$volid};
my ($path, $owner) = PVE::Storage::path($self->{storecfg}, $volid); my ($path, $owner) = PVE::Storage::path($self->{storecfg}, $volid);
die "can't migrate volume '$volid' - owned by other VM (owner = VM $owner)\n" die "can't migrate volume '$volid' - owned by other VM (owner = VM $owner)\n"
if !$owner || ($owner != $self->{vmid}); if !$owner || ($owner != $self->{vmid});
$volhash->{$volid} = 1; if (defined($snapname)) {
}); # we cannot migrate shapshots on local storage
# exceptions: 'zfspool' or 'qcow2' files (on directory storage)
my $format = PVE::QemuServer::qemu_img_format($scfg, $volname);
if (($scfg->{type} eq 'zfspool') || ($format eq 'qcow2')) {
$volhash->{$volid} = 1;
return;
}
die "can't migrate snapshot of local volume '$volid'\n";
} else {
$volhash->{$volid} = 1;
}
};
PVE::QemuServer::foreach_volid($conf, $test_volid);
foreach $snapname (keys %{$conf->{snapshots}}) {
PVE::QemuServer::foreach_volid($conf->{snapshots}->{$snapname}, $test_volid);
}
if ($self->{running} && !$sharedvm) { if ($self->{running} && !$sharedvm) {
die "can't do online migration - VM uses local disks\n"; die "can't do online migration - VM uses local disks\n";