From 33f8b88782a0cfdd252855937ddf4e9bb364603e Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Thu, 4 Nov 2021 08:45:31 +0100 Subject: [PATCH] agent hotplug: small style cleanups & comment addition Signed-off-by: Thomas Lamprecht --- PVE/QemuServer.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 66b924f3..8e368489 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5015,17 +5015,17 @@ sub vmconfig_update_agent { my $old_agent = parse_guest_agent($conf); my $agent = parse_guest_agent({$opt => $value}); - #added/changed options - foreach my $option (keys %$agent) { + for my $option (keys %$agent) { # added/changed options next if defined($hotplug_options->{$option}); die "skip\n" if safe_string_ne($agent->{$option}, $old_agent->{$option}); } - #removed options - foreach my $option (keys %$old_agent) { + for my $option (keys %$old_agent) { # removed options next if defined($hotplug_options->{$option}); die "skip\n" if safe_string_ne($old_agent->{$option}, $agent->{$option}); } + + return; # either no actual change (e.g., format string reordered) or just hotpluggable changes } sub vmconfig_update_disk {