From 2fb78e6cd2be5d88f3f53a7929fb51af00d4e214 Mon Sep 17 00:00:00 2001 From: Mira Limbeck Date: Mon, 18 Nov 2019 15:41:14 +0100 Subject: [PATCH] close #2263: die on live migration with local cloudinit disk Live migration with a local cloudinit disk was never intended to work. It did however work to an extent that the migration completed but the disk on the source node could not be deleted. Now die if a live migration is started with a local cloudinit disk. With the GUI changes live migration is already disabled as it recognizes the cloudinit disk as a local resource. Signed-off-by: Mira Limbeck (cherry picked from commit 9860fe4ef992e8550f8dee9aed65e2fed75c470f) Signed-off-by: Oguz Bektas --- PVE/QemuMigrate.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 94bc40c0..65f39b6e 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -458,6 +458,7 @@ sub sync_disks { if ($self->{running} && $ref eq 'config') { push @{$self->{online_local_volumes}}, $volid; } elsif ($ref eq 'generated') { + die "can't live migrate VM with local cloudinit disk. use a shared storage instead\n" if $self->{running}; # skip all generated volumes but queue them for deletion in phase3_cleanup push @{$self->{volumes}}, $volid; next;